Skip to content

Conversation

@wbpcode
Copy link
Member

@wbpcode wbpcode commented Oct 23, 2025

Commit Message: formatter: add formal full name for some commands
Additional Description:

To make the naming more clear. And we can also to support request trailers in the future.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.

@RyanTheOptimist
Copy link
Contributor

/assign @botengyao

@wbpcode
Copy link
Member Author

wbpcode commented Oct 24, 2025

/retest

@wbpcode wbpcode enabled auto-merge (squash) October 25, 2025 12:34
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and thanks for making it more user friendly.

/wait

TCP/UDP
Not implemented ("-").

%RESP(X?Y):Z%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we still keep the short version usage doc and add the new one in the meantime?

Copy link
Member Author

@wbpcode wbpcode Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the document, I think we can keep it or remove it anyway. For the code implementation, because the short version is widely used, we'd better to keep it.

And for now, both versions was kept to avoid to confuse exist users.

Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the change.

@wbpcode
Copy link
Member Author

wbpcode commented Oct 28, 2025

/retest

@wbpcode wbpcode merged commit 2546bcd into envoyproxy:main Oct 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants