- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.1k
formatter: add formal full name for some commands #41670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: WangBaiping <[email protected]>
| /assign @botengyao | 
| /retest | 
…lear-name-of-formatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, and thanks for making it more user friendly.
/wait
| TCP/UDP | ||
| Not implemented ("-"). | ||
|  | ||
| %RESP(X?Y):Z% | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we still keep the short version usage doc and add the new one in the meantime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the document, I think we can keep it or remove it anyway. For the code implementation, because the short version is widely used, we'd better to keep it.
And for now, both versions was kept to avoid to confuse exist users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the change.
| /retest | 
Commit Message: formatter: add formal full name for some commands
Additional Description:
To make the naming more clear. And we can also to support request trailers in the future.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.